Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmata building with Yotta on nRF52833 #7

Closed
wants to merge 2 commits into from
Closed

Firmata building with Yotta on nRF52833 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5e6074
builds with yotta
microbit-sam Oct 27, 2020
e07400d
fix up comments
microbit-sam Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions firmware/module.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@
"name": "mbFirmata",
"version": "1.0.0",
"description": "The micro:bit runtime common abstraction with examples.",
"license": "MIT",
"license": "Apache-2.0",
"dependencies": {
"microbit": "lancaster-university/microbit#v2.1.1"
"codal-microbit": "microbit-foundation/codal-microbit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we switch this and the previous dep to both be targetDependencies so we can change which dal we want based on the target.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to change the license to Apache 2.0? Even if Codal is Apache 2.0, micro:bit Firmata can be MIT; they are compatible licenses.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jhmaloney. Just FYI, Codal is licensed as MIT...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not intentionally, possibly defaulted to it when I yotta init'd the directory. I'll correct that in the next commit!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know!

},
"targetDependencies": {},
"bin": "source"
"bin": "./source",
"private": true,
"author": ""
}
Loading