Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vendorId for windows (0D28) #4

Merged
merged 3 commits into from
Feb 20, 2023
Merged

added vendorId for windows (0D28) #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41b4a3d
added vendorId for windows (0D28)
cpietsch Dec 15, 2019
dc234b1
added promise return to connect()
cpietsch Dec 15, 2019
885d110
Merge branch 'master' into master
JohnVidler Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions client/MBFirmataClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class MicrobitFirmataClient {
.then((ports) => {
for (var i = 0; i < ports.length; i++) {
var p = ports[i];
if ((p.vendorId == '0d28' || p.vendorId == '0D28') && (p.productId == '0204')) {
if ((p.vendorId == "0d28" || p.vendorId == "0D28") && (p.productId == '0204')) {
return p.comName;
}
}
Expand All @@ -168,6 +168,7 @@ class MicrobitFirmataClient {
console.log("No micro:bit found; is your board plugged in?");
return null;
}
return null
});
}

Expand Down Expand Up @@ -199,7 +200,7 @@ class MicrobitFirmataClient {
this.boardVersion = this.boardVersionFromSerialNumber(p.serialNumber);
}
}
return null;
return this;
})
}

Expand Down