[Code.org Integration] Compass Calibration Placeholder #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing the mock-up; I'm working on getting this added, along with a couple of other missing features of the V2, and will update this PR when its complete. |
Added in call to calibrate the compass, and done some minor formatting. Also added correct python version and javascript serial package information
|
Ended up just merging the required changes for compass calibration, and this is now done at the start of the sensors test in I'm currently on a Mac, and don't have any clients installed (or know of a relevant web client) to test this on, so feedback is required before merging this in. |
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the Code.org/micro:bit integration.
We would like to allow students to calibrate the compass from the board setup page (studio.code.org/maker/setup). We are asking for a compass calibration function to be surfaced to MBFirmataClient.js. I've mocked up what those function calls might looks like in this PR, but feel free to adjust the API as needed.