Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize multiple examples on one slot #42

Closed
Tracked by #587
turbomam opened this issue Feb 15, 2022 · 9 comments · Fixed by microbiomedata/submission-schema#17
Closed
Tracked by #587

standardize multiple examples on one slot #42

turbomam opened this issue Feb 15, 2022 · 9 comments · Fixed by microbiomedata/submission-schema#17
Assignees

Comments

@turbomam
Copy link
Member

turbomam commented Feb 15, 2022

  • with semicolon: 'tree; chair'
  • with "or": 'tree or chair'
  • with vertical pipe character: 'tree|chair'
  • as two individual examples:
    • tree
    • chair
@turbomam turbomam self-assigned this Feb 15, 2022
@turbomam
Copy link
Member Author

going with semicolon for now

@mslarae13
Copy link

@turbomam what is left to do here?

@mslarae13
Copy link

mslarae13 commented Feb 15, 2023

Suggestion: Pipe | used to separate multiple values ... ; used to separate the individual tokens within a compound value

Need to define multi-valued slot vs compound value and compound value pattern + multi-valued = true

agrochem_addition example doesn't validate. Need to revisit this.

  • need 2 valid examples
  • Mark will check this slot as a test case
  • check NCBI relational database, how is this used?

@mslarae13
Copy link

microbiomedata/issues#78

@mslarae13
Copy link

@turbomam how is this coming? Will you be able to finish by the end of the sprint?

@ssarrafan
Copy link

This appears to be active so I will move to the next sprint. @mslarae13 thank you for trying to get an update on this.

@pkalita-lbl
Copy link
Collaborator

DH already uses the multivalued nature of the examples metamodel slot to show different examples as separate bullets. We need to write our examples to take advantage of that. In some cases that may mean overriding the MIxS examples.

Some good slots to consider:

  • collection time
  • extreme_unusual_properties/heavy metals
  • agrochem_addition

@pkalita-lbl pkalita-lbl assigned pkalita-lbl and unassigned turbomam Mar 8, 2023
@pkalita-lbl
Copy link
Collaborator

End of sprint update: this one came in late, but I intend to work on it in the next sprint.

@turbomam
Copy link
Member Author

Great. I think there are still non-standardized multiple examples that come straight from GSC. I'll work on those.

@mslarae13 mslarae13 moved this from ✅ Done to Complete- SubPort1 in SubPort Squad Issues Jun 27, 2024
@mslarae13 mslarae13 moved this from Complete- SubPort1 to ✅ Done in SubPort Squad Issues Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ SubPort 1 - Done
Development

Successfully merging a pull request may close this issue.

4 participants