Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"air temperature" and "absolute air humidity" example help text fails on validation #140

Closed
pvangay opened this issue Jun 24, 2022 · 4 comments
Assignees
Milestone

Comments

@pvangay
Copy link

pvangay commented Jun 24, 2022

Using the built environment template, a Champion reported that several examples in the help text failed on validation:

  • For "air temperature": "20 degree Celsius" is provided as an example but did not validate. "20 degree" did pass validation.
  • For "absolute air humidity": "9 gram per gram" is provided as an example but did not validate

Please update either the validation or example to be consistent.

@pvangay pvangay changed the title "air temperature" example fails on validation "air temperature" and "absolute air humidity" example help text fails on validation Jun 24, 2022
@turbomam
Copy link
Member

Currently, all columns whose range is MIxS measurement value aka NMDC quantity value don't allow spaces in the units portion. I can change that globally, but we should think about whether that would have any undesired consequences

@pvangay
Copy link
Author

pvangay commented Jun 24, 2022

sounds like a good topic of discussion at the next metadata meeting? (to identify a path forward and discuss undesired consequences). @mslarae13

I don't have a strong feeling either way - we just need to be consistent with what we provide as an example vs. how we validate

@ssarrafan
Copy link

@turbomam moving this to Sept but please let me know if you're not actively working on it for the next 2 weeks

@mslarae13
Copy link

I assume this is actually ' humidity_regm' in which case, both work now. However we might want to make (unless one exists) a ticket for "updating and improving guidance and examples in template"

Repository owner moved this from Todo to Done in NMDC September 1-16 2022 Sprint Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants