Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename or reconstitute "Sample ID" section #137

Closed
Tracked by #587
turbomam opened this issue Jun 23, 2022 · 9 comments
Closed
Tracked by #587

Rename or reconstitute "Sample ID" section #137

turbomam opened this issue Jun 23, 2022 · 9 comments
Assignees

Comments

@turbomam
Copy link
Member

Most of the columns in our DH "Sample ID" section aren't identifiers of samples.

We should move these columns into a different section or rename this section to soemthing like "Sample ID and background"

Yes, identifiers:

  • samp_name
  • sample_link ???
  • source_mat_id

No, not identifiers


  • ecosystem
  • ecosystem_category
  • ecosystem_subtype
  • ecosystem_type
  • specific_ecosystem

  • env_broad_scale
  • env_local_scale
  • env_medium

CC @mslarae13

@ssarrafan
Copy link

@turbomam moving this to Sept but please let me know if you're not actively working on it for the next 2 weeks

@mslarae13
Copy link

Could do sample description? I'm ok with generalizing the category.

@ssarrafan
Copy link

Discussed with @turbomam and moving to the backlog.

@ssarrafan
Copy link

@turbomam is this one being actively worked on now? I saw it under your squad board with "in progress".

@ssarrafan
Copy link

@turbomam @mslarae13 @sujaypatil96 is this issue still in progress, actively being worked on?

@ssarrafan
Copy link

Moving to next sprint since Mark is on vacation this week.

@turbomam
Copy link
Member Author

turbomam commented Dec 5, 2022

@ssarrafan this shouldn't be associated with https://github.com/orgs/microbiomedata/projects/34 anymore. It is moderately important and should be included in some future schema general maintenance squad (or hackathon)

@ssarrafan
Copy link

@turbomam Ok I will remove it from this sprint and the Deino board and add the backlog label to it.

@ssarrafan
Copy link

Over a year old, no updates. Closing this issue. @turbomam @mslarae13 FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants