Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"environmental package" and GOLD ecosystem terms are limited to soil for all 12 MIxS packages #123

Open
Tracked by #587
pvangay opened this issue Apr 27, 2022 · 8 comments
Assignees

Comments

@pvangay
Copy link

pvangay commented Apr 27, 2022

This happens regardless of what MIxS package I load. The other terms in the template seem appropriate for the selected environmental package -- but it seems to be that perhaps the allowable values here are just restricted incorrectly?

image

image

@turbomam
Copy link
Member

Yes, I'm aware of that. We discussed it a little in some meeting. I can't remember who was there or what decision we came to. I think I'm supposed to leave the GOLD path pulldowns empty for all package templates. If you have input I can still act on it. I'm more likely to have success with soemthing that's global, not tuned for individual templates.

@pkalita-lbl is experimenting with solutions for pulldowns that would be dependent on the values in other pulldowns.

Back to my meeting...

@pvangay
Copy link
Author

pvangay commented Apr 27, 2022

Best to leave these values empty for all other packages except Soil. I think you did this for the EnvO terms right? users may think that they don't have the correct template loaded.

it's it's too hard to enable it for soil only, i would just remove it for all packages given the release being so soon.

@turbomam
Copy link
Member

@pvangay I am going to start by changing these globally. The MIxS environmental triad columns and the GOLD path columns will all be blank and require strings that match their patterns.

I will try to add the previous support for pulldowns back into all of the soil related templates but don't know how that will goo.

@turbomam
Copy link
Member

GOLD paths: edit modifications_long tab on nmdc-dh-sheets-mam-non-anno

specifically, the ranges for

  • ecosystem
  • ecosystem_category
  • ecosystem_subtype
  • ecosystem_type
  • specific_ecosystem

from enums like ecosystem_enum to string

@turbomam
Copy link
Member

@pvangay

Check this out at https://microbiomedata.github.io/sheets_and_friends/linkml.html

The previous GOLD pulldowns are now active for soil templates but disabled for all others. We can curate lists for each column per each other environment, but there's noting in place yet guaranteeing that the columns values go together in a reasonable way.

@turbomam
Copy link
Member

The MIxS environmental triad columns are all free-form for all enviroment templates now. Tomorrow I'll let you know what else I can pull off by Friday.

@turbomam
Copy link
Member

Oh shoot, the first part of this issue is about the environment column, not the MIxS columns. There's another issue for that somewhere isn't there?

@pvangay
Copy link
Author

pvangay commented Apr 27, 2022

GOLD terms look good. but "environment package" is still showing soil only (i'm on the air template).
image

This is the other issue: #118 -- enable EnvO triad dropdowns for the soil templates. if you're able to also keep dropdowns for GOLD ecosystem path for soil templates too - that'd be great. but we agreed that for now, it's ok to remove Envo and GOLD dropdowns for all templates until you are able to find a way to make it work. thanks mark!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants