Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperlinks to GOLD and IMG #5

Open
cmungall opened this issue Jan 29, 2020 · 5 comments · Fixed by #11
Open

Add hyperlinks to GOLD and IMG #5

cmungall opened this issue Jan 29, 2020 · 5 comments · Fixed by #11

Comments

@cmungall
Copy link

cmungall commented Jan 29, 2020

E.g.

image

has an ID Gb0139760

I think this should link to https://gold.jgi.doe.gov/biosample?id=Gb0139760

(although this gives me "Error: Not found or insufficient access rights".. @dehays says there may be something on the gold side that prevents URL hacking)

Note to @wdduncan we should use CURIEs (prefixed IDs) throughout. We can register prefixes on identifiers.org or n2t.net and automate linking. See microbiomedata/nmdc-metadata#2

@dehays
Copy link

dehays commented Jan 29, 2020

Chris - I realize that this might not be some 'GOLD preventing URL hacking' thing. What I hit yesterday and quite likely what you are seeing here is that Gb0139760 is NOT an active biosample in GOLD and the "Not available" message from GOLD is accurate.

@dehays
Copy link

dehays commented Jan 29, 2020

@cmungall - That biosample is not found because it is not an active biosample record in GOLD. URLS with active GOLD biosamples work.

@jeffbaumes
Copy link
Collaborator

I've addressed this in #11. It is deployed to github pages and you can try it out on single-item pages, e.g. https://microbiomedata.github.io/pilot/project?q=%5B%7B%22field%22%3A%22id%22,%22op%22%3A%22%3D%3D%22,%22value%22%3A%22Gp0095972%22%7D%5D. Is this helpful for now? We can adjust to use prefixed IDs when they are available.

@cmungall
Copy link
Author

cmungall commented Feb 3, 2020

@elishawc what do you think?

To me I think it's not totally obvious. I would combine the display of the ID with the link to the external resource (where GOLD is considered external here)

I made a ticket for handling of IDs in the portal in general: #16

@jeffbaumes jeffbaumes reopened this Feb 6, 2020
@jeffbaumes
Copy link
Collaborator

@cmungall @elishawc The UI may depend on what is meant by the "id" attribute in NMDC. It currently seems to be a "source ID" to GOLD, though IDs from other systems will be coming in, and it also seems reasonable that there may someday be a NMDC-specific global identifier scheme independent of the source ID. For now I am assuming "id" is an NMDC ID, and for GOLD data added a separate "Open in GOLD" line to link out to GOLD.

This issue may sort out in #16, in which case future data will be more clear what ID points to where, and the UI can update accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants