Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize R API wrapper functions #90

Open
3 tasks
bmeluch opened this issue Nov 13, 2024 · 1 comment · May be fixed by #103
Open
3 tasks

Modularize R API wrapper functions #90

bmeluch opened this issue Nov 13, 2024 · 1 comment · May be fixed by #103

Comments

@bmeluch
Copy link
Contributor

bmeluch commented Nov 13, 2024

Currently, the taxonomy and NOM R notebooks define functions for interacting with the NMDC API. The functions are essentially the same. (e.g. cell 2 here)

Rather than copy pasting the same code into every new notebook, it would be better to pull those functions out into an R package accessible by all notebooks in this repo.

Completion criteria:

  • An R package exists in this repo containing the API interaction functions we've written so far
  • The existing notebooks use functions from the package and no longer define them internally
  • It plays nicely with our renv .lock file (someone newly cloning the repo can run the notebooks after using renv::restore() )
@bmeluch
Copy link
Contributor Author

bmeluch commented Dec 10, 2024

Dealing with R packages nested in a repo is messy, so I'm going to start over with just making an R script of functions to call.

@bmeluch bmeluch linked a pull request Dec 10, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant