Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test if biosmaple_set from gold_nmdc_pipeline.py passes 7.1.6 validation #590

Closed
turbomam opened this issue Jan 9, 2023 · 3 comments
Closed

test if biosmaple_set from gold_nmdc_pipeline.py passes 7.1.6 validation #590

turbomam opened this issue Jan 9, 2023 · 3 comments
Assignees
@turbomam
Labels
gold validation Related to validation of data

Comments

@turbomam
Copy link
Member

turbomam commented Jan 9, 2023

See https://github.com/microbiomedata/sample-annotator/blob/main/sample_annotator/clients/gold_nmdc_pipeline.py
@turbomam turbomam self-assigned this Jan 9, 2023
@sujaypatil96
Copy link
Collaborator

Latest JSON output that can be generated after running the updated transformation script here: microbiomedata/sample-annotator#113 does in fact pass v7.1.6 validation.

@turbomam
Copy link
Member Author

does in fact pass v7.1.6 validation

Unfortunately, the validation isn't catching cases in which the nmdc prefix has been used with GOLD local ids.

@turbomam turbomam mentioned this issue Jan 24, 2023
Closed
@turbomam turbomam added the gold label Feb 16, 2023
@eecavanna eecavanna added the validation Related to validation of data label Sep 6, 2023
@aclum
Copy link
Contributor

aclum commented Nov 8, 2023

@sujaypatil96 can this be closed?

@aclum aclum closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turbomam turbomam

Labels
gold validation Related to validation of data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aclum @sujaypatil96 @turbomam @eecavanna