-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JGI Plate well description #580
Comments
@turbomam |
@mslarae13 @turbomam is this issue being actively worked on? |
Haven't heard back so removing from sprint |
This is a reasonable issue, but
isn't a description. We should create an actual description and capture this kind of knowledge in comments. Blank entries are allowed now so I wouldn't recommend entering 'NA'. In fact, I don't think NA will validate. There's a DataHarmonizer issue to address an implementation that won't require this workaround at all. But I don't think there's any development on that yet. I haven't created the necessary rule in the schema yet either. |
I'm starting to work on this now. You're talking about slot |
@sujaypatil96 pointed out that the place that text appears in the Data Portal is in the |
So my pet peeve about descriptions vs comments is irrelevant here! |
Comments and rules have been written to address this. Enforcement of the rules in DataHarmonizer has not been, but has been raised as an issue in the DataHarmonizer issue tracker. |
Currently, the description for plate well is
"Required when 'plate' is selected for container type. Corner wells must be blank. For partial plates, fill by columns. Leave blank if the sample will be shipped in a tube."
Should be
"Required when 'plate' is selected for container type. Corner wells must be blank. For partial plates, fill by columns. Provide "NA" if the sample will be shipped in a tube."
Completion involves updating the schema and merging the change into main.
The text was updated successfully, but these errors were encountered: