Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Update notebook dependencies to accommodate nmdc-schema dependency requirements #561

Closed
1 task done
eecavanna opened this issue Jun 19, 2024 · 0 comments · Fixed by #562
Closed
1 task done
Assignees
Labels
bug Something isn't working X SMALL Less than 1 day

Comments

@eecavanna
Copy link
Collaborator

eecavanna commented Jun 19, 2024

Background

In nmdc-schema version v10.3.0, the pymongo requirement was pymongo = "^4.3.3".

In nmdc-schema version v10.5.4, the pymongo requirement is pymongo = "^4.7.2".

Problem

A migration notebook was recently introduced into this repository via PR #558.

Because it uses nmdc-schema v10.5.4, it requires pymongo==^4.7.2. However, its requirements.txt file currently indicates that it requires pymongo==4.5.0 (source).

The reason the notebook's requirements.txt file is not coherent with the notebook is that I forgot to git add the local changes I made to the requirements.txt file when I introduced the notebook into this repository.

Task

  • Update the requirements.txt file so that it says pymongo==4.7.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working X SMALL Less than 1 day
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant