Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changesheet validator throws error when using remove item for a single-value field #498

Closed
PeopleMakeCulture opened this issue Mar 20, 2024 · 1 comment · Fixed by #499
Closed

changesheet validator throws error when using remove item for a single-value field #498

PeopleMakeCulture opened this issue Mar 20, 2024 · 1 comment · Fixed by #499
Assignees
@PeopleMakeCulture
Labels
unplanned-task not accounted for during sprint planning, but time sensitive

Comments

@PeopleMakeCulture
Copy link
Collaborator

PeopleMakeCulture commented Mar 20, 2024 •
edited
Loading

@brynnz22 submitted a bug with the changesheet:validates endpoint, where the validator throws an error when using remove item with a single-value field
@PeopleMakeCulture PeopleMakeCulture converted this from a draft issue Mar 20, 2024
@dwinston dwinston changed the title changesheet validator throws error when using remove item for a single item changesheet validator throws error when using remove item for a single-value field Mar 20, 2024
@dwinston
Copy link
Collaborator

The correct action to specify for this intent is remove (or delete), as per this code block:

https://github.com/microbiomedata/nmdc-runtime/blob/v1.4.1/nmdc_runtime/api/core/metadata.py#L505-L530

However, this action is missing from the how-to guide:

https://github.com/microbiomedata/nmdc-runtime/blob/v1.4.1/docs/howto-guides/author-changesheets.md

@PeopleMakeCulture PeopleMakeCulture mentioned this issue Mar 20, 2024
Merged
5 tasks
@PeopleMakeCulture PeopleMakeCulture self-assigned this Mar 20, 2024
@PeopleMakeCulture PeopleMakeCulture added the unplanned-task not accounted for during sprint planning, but time sensitive label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeopleMakeCulture PeopleMakeCulture

Labels
unplanned-task not accounted for during sprint planning, but time sensitive
Projects
Polyneme mixset
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update docs for changesheet validator to include remove action microbiomedata/nmdc-runtime
2 participants
@dwinston @PeopleMakeCulture