Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subClassOf cycles in nmdco-classes.json breaks the nmdc-server ingest #49

Closed
turbomam opened this issue Mar 15, 2024 · 1 comment · Fixed by #52
Closed

subClassOf cycles in nmdco-classes.json breaks the nmdc-server ingest #49

turbomam opened this issue Mar 15, 2024 · 1 comment · Fixed by #52

Comments

@turbomam
Copy link
Member

In recent builds of nmdco-classes.json, there has been a cycle between ChEBI's role CHEBI:50906 and BFO's role BFO:0000023. See image below.

This can be observed by configuring and starting the nmdc-server Docker environment, accessing the backend container's shell and running

nmdc-server ingest

The relevant error here is

Updating NMDC functions for the active database.
...
File "/app/nmdc_server/ingest/envo.py", line 29, in populate_envo_ancestor
raise Exception(f"Cyclic graph detected ({node})")
Exception: Cyclic graph detected (CHEBI:50906)

And comes from https://github.com/microbiomedata/nmdc-server/blame/10cdc936387b7be890890d225b59875f0a83718e/nmdc_server/ingest/envo.py#L16-L29

I believe I found the most recent nmdco-classes.json that does parse, and I retroactively made a release

https://raw.githubusercontent.com/microbiomedata/nmdc-ontology/2024-02-16/nmdco-classes.json

image

@turbomam
Copy link
Member Author

Moving parts:

@turbomam turbomam linked a pull request Mar 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant