Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace variables named template with templateName where appropriate #209

Open
pkalita-lbl opened this issue Dec 11, 2024 · 0 comments
Open

Replace variables named template with templateName where appropriate #209

pkalita-lbl opened this issue Dec 11, 2024 · 0 comments
Labels
cleanup 🧹 Related to cleaning up code, whether its format, organization, variable names, etc.

Comments

@pkalita-lbl
Copy link
Collaborator

This is a follow-on task identified in #208.

There are many places scattered throughout the code where we have a variable named template that is typed with the TemplateName type. It was suggested that it might be more clear if those variables were named templateName to indicate that they contain a string (actually one of a specific set of strings) rather than one of the values from the TEMPLATES object.
@pkalita-lbl pkalita-lbl added the cleanup 🧹 Related to cleaning up code, whether its format, organization, variable names, etc. label Dec 11, 2024
@pkalita-lbl pkalita-lbl mentioned this issue Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup 🧹 Related to cleaning up code, whether its format, organization, variable names, etc.
Projects
Field Notes Squad Board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pkalita-lbl