Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for changes to packageName field on backend #177

Closed
pkalita-lbl opened this issue Sep 16, 2024 · 9 comments · Fixed by #208
Closed

Account for changes to packageName field on backend #177

pkalita-lbl opened this issue Sep 16, 2024 · 9 comments · Fixed by #208
Assignees

Comments

@pkalita-lbl
Copy link
Collaborator

Part of the proposed changes for microbiomedata/nmdc-server#1367 is changing the packageName field of a submission object from a string to an array of strings. This will break certain things in the app. We need to sort out:

  1. How the app will handle this change. What would it look like to fully support creating, displaying, and updating studies that use multiple environment templates? Is it simpler to continue to only support a single environment template in the app?
  2. How will we coordinate releasing app changes along with the backend changes? Is it possible to update the app to work with either a string or array of strings in packagename and release that change ahead of the backend changes?
@pkalita-lbl
Copy link
Collaborator Author

Cross-linking the proposed backend changes here: microbiomedata/nmdc-server#1372

@ssarrafan
Copy link
Collaborator

@pkalita-lbl who should this one be assigned to?

@pkalita-lbl
Copy link
Collaborator Author

The work on this is paused until microbiomedata/nmdc-server#1367 is resolved. I believe that work is paused until after the Berkeley refactor roll-out is complete. Moving to next sprint.

@ssarrafan
Copy link
Collaborator

ssarrafan commented Oct 17, 2024

Berkeley was rolled out so can this be closed @pkalita-lbl ?
Moving to next sprint since Patrick is out till next week.

@pkalita-lbl
Copy link
Collaborator Author

This cannot be closed.

It doesn't really have anything to do with Berkeley. The gating factor is the PR for microbiomedata/nmdc-server#1367 being merged in.

@pkalita-lbl
Copy link
Collaborator Author

Still paused waiting for microbiomedata/nmdc-server#1367. Moving to next sprint.

@pkalita-lbl
Copy link
Collaborator Author

Still paused waiting for microbiomedata/nmdc-server#1367. Moving to next sprint.

@ssarrafan
Copy link
Collaborator

@pkalita-lbl update from @marySalvi on issue #1367:
Yes, this will be ready for the December release. This has been blocked by the bug in the runtime code (my runtime code). I have made good progress towards a resolution and am hoping to wrap this up shortly.

Based on this can I move this to the next sprint?

@pkalita-lbl
Copy link
Collaborator Author

I moved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants