Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isotope label enumeration doesn't work with existing NMDC isotope slot #14

Open
Tracked by #5
mslarae13 opened this issue May 26, 2023 · 3 comments
Open
Tracked by #5
Labels
backlog Issues delayed / low priority

Comments

@mslarae13
Copy link
Contributor

mslarae13 commented May 26, 2023

The NMDC slot 'isotope_exposure" can be used to inform the JGI template column "Isotope label".

In the JGI template, it's an enumeration (C13, N15, O18, Unlabeled).

NMDC doesn't have an enumeration & it is expected to include the compound that is labeled (13C glucose (C13 glucose), H218O, 15NH4+).

In theory, we can extrapolate the correct JGI enum from what we collection.. but it isn't easy, and it's error prone.

Looking for some comments / feedback on how we should handle this.
@turbomam , @cmungall , @emileyfadrosh , @aclum

Some options:

  • Add a JGI isotope slot
    • Pros: clear mapping to JGI
    • Cons: more columns, more slots, repeat details
  • Make isotope_exposure more general and enumerated to match JGI, assuming the chemical that is labeled will be captured somewhere else (chem administration?)
    • Pros: clear mapping to JGI, clearer metadata in NMDC, will be a closer map to GSC v7 with addition of SIP checklists
    • Cons: more columns, more slots
@mslarae13 mslarae13 changed the title Isotope label enumeration Isotope label enumeration doesn't work with existing NMDC isotope slot May 26, 2023
@aclum
Copy link

aclum commented May 31, 2023

I'd vote for 'Make isotope_exposure more general and enumerated to match JGI, assuming the chemical that is labeled will be captured somewhere else (chem administration?)' since it has more pros that the other option.

@mslarae13 mslarae13 added the backlog Issues delayed / low priority label Jul 7, 2023
@ssarrafan
Copy link

@mslarae13 @aclum can this be closed?

@mslarae13
Copy link
Contributor Author

no this is not resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues delayed / low priority
Projects
None yet
Development

No branches or pull requests

3 participants