Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readqc not always specifying the correct output file #7

Closed
aclum opened this issue Aug 9, 2024 · 1 comment · Fixed by #8
Closed

readqc not always specifying the correct output file #7

aclum opened this issue Aug 9, 2024 · 1 comment · Fixed by #8
Assignees

Comments

@aclum
Copy link

aclum commented Aug 9, 2024

The issue is with this line

File filtered = glob("filtered/*fastq.gz")[0]

I this is not deterministic so sometimes you end up with the correct file and sometimes you end up with the rRNA file.

For this run the file that should be input to assembly is 3.6 G
nmdcda@perlmutter:login02:/pscratch/sd/n/nmjaws/nmdc-prod/cromwell-executions/nmdc_metaT/31b007af-e328-40a7-926c-47ccb1f4789a/call-qc/metaTReadsQC/5fcf96a7-c485-4675-8df6-76573a8c8c06/call-qc/execution/filtered> ls -lh *fastq.gz
-rw-rw-r--+ 2 nmjaws nmjaws 3.6G Aug 7 15:37 raw.anqrpht.fastq.gz
-rw-r--r--+ 11 nmjaws nmjaws 1.1G Aug 7 13:29 rRNA.fastq.gz

The finalize step the file size is the same for the rrna file and the clean file
(nersc-python) nmdcda@perlmutter:login02:/pscratch/sd/n/nmjaws/nmdc-prod/cromwell-executions/nmdc_metaT/31b007af-e328-40a7-926c-47ccb1f4789a/call-qc/metaTReadsQC/5fcf96a7-c485-4675-8df6-76573a8c8c06/call-finish_rqc/execution> ls -lh *fastq.gz
-rw-r--r--+ 11 nmjaws nmjaws 1.1G Aug 7 13:29 Ga0491221_filtered.fastq.gz
-rw-r--r--+ 11 nmjaws nmjaws 1.1G Aug 7 13:29 Ga0491221_rRNA.fastq.gz

Please update the code to use a file suffix of 'anqrpht.fastq.gz' for the filtered output of task rqcfilter

@kaijli
Copy link
Collaborator

kaijli commented Aug 14, 2024

Created a branch, will merge when benchmark reruns confirmed good

@kaijli kaijli linked a pull request Aug 15, 2024 that will close this issue
@kaijli kaijli closed this as completed in #8 Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants