Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better connection pool handling #2725

Merged
merged 19 commits into from
Jul 23, 2024
Merged

Conversation

Ak-Army
Copy link
Contributor

@Ak-Army Ak-Army commented Jul 23, 2024

Better connection pool handling.
Add ability to set connection close timeout.
Hide mutex from outside.

xpunch and others added 19 commits December 17, 2021 11:43
* [fix] micro#2431 http transport data race issue
# Conflicts:
#	client/rpc_stream.go
# Conflicts:
#	plugins/config/source/etcd/etcd.go
Ability to send messages while receiving.
Icreased r channel limit to 100 to more fluently communication.
Do not dropp sent request if r channel is full.
…the transport client is closed in the rpc codec
…_close_problem_in_pool

# Conflicts:
#	go.mod
@asim
Copy link
Member

asim commented Jul 23, 2024

It needs to pass the test to be merged. Make sure to merge master into your branch

@Ak-Army
Copy link
Contributor Author

Ak-Army commented Jul 23, 2024

The master is fully merged into the branch. Test pass in my local machine, but in CI something went wrong.
Can you check the CI pls, tehere is a lot of interesting message.

PASS | MemoryBroker (0.00s)
     | goos: linux
     | goarch: amd64
     | pkg: go-micro.dev/v5/broker
     | cpu: AMD EPYC 7763 64-Core Processor                
     | BenchmarkSub1
     | BenchmarkSub1-4     	    3334	    343432 ns/op
     | BenchmarkSub8
     | BenchmarkSub8-4     	   14389	     80134 ns/op
     | BenchmarkSub32
     | BenchmarkSub32-4    	   1[58](https://github.com/micro/go-micro/actions/runs/10053665623/job/27786845069?pr=2725#step:5:59)01	     72746 ns/op
     | BenchmarkSub64
     | 2024/07/23 06:09:48 http: Accept error: accept tcp 127.0.0.1:34[62](https://github.com/micro/go-micro/actions/runs/10053665623/job/27786845069?pr=2725#step:5:63)1: accept4: too many open files; retrying in 5ms

@asim asim merged commit 0433e98 into micro:master Jul 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants