Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate exceptions correctly from setSLMImage() #87

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Propagate exceptions correctly from setSLMImage() #87

merged 1 commit into from
Sep 28, 2023

Conversation

marktsuchida
Copy link
Member

Closes #76.

tlambert03
tlambert03 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@marktsuchida marktsuchida merged commit 03f60a3 into main Sep 28, 2023
17 checks passed
@marktsuchida marktsuchida deleted the fix-set-slm-image-exception-handling branch September 28, 2023 20:30
@marktsuchida marktsuchida mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlambert03 tlambert03 tlambert03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with error handling in setSLMImage
2 participants
@marktsuchida @tlambert03