Fix macOS CI #117
Merged
Fix macOS CI #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macos-11 is deprecated and will be removed on 2024-06-28.
|
that seems to have done it 😂 |
oh never mind... we'll need to temporarily let the |
|
Presumably the cause was that the SWIG binary we're using crashes on macOS 11 (but not 12). I suspected that it was built for 12+ but $ otool -l venv/lib/python3.11/site-packages/swig/data/bin/swig |grep minos
minos 11.0(PyPI (Or maybe it was some other weird transient issue, but I'm happy it's fixed!) |
marktsuchida
force-pushed
the
fix-ci-macos-wheels
branch
from
2aa9a67 to
15ed019
Compare
|
(Force-pushed to re-disable wheels for PRs.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress -- as I haven't managed to reproduce the issue locally.Upgrade to macos-12 for wheel building.