Update Contributing.md with documentation on tests #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! The only feedback I have is that maybe it would be good to point novices towards a conda release that has conda-forge as the default channel. Pycromanager ends up there, and I'm not sure if it ends up in the conda channel associated with, for example, anaconda (I also don't know what this channel is called). For what its worth, I always use mambaforge to set up my python envs now. |
|
Oh, I've never tried that, I always install it through |
|
On second thought, maybe this isn't needed. I always do pip also, and im pretty sure there's no difference (except that conda might be slightly out of date) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #608
@henrypinkard let me know what you think about the simplification in the git instructions, we can easily revert these changes