Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMCoreJ build: simplify mvn build #408

Merged
merged 2 commits into from
Dec 1, 2023
Merged

MMCoreJ build: simplify mvn build #408

merged 2 commits into from
Dec 1, 2023

Conversation

nicost
Copy link
Member

@nicost nicost commented Nov 29, 2023

No longer need to move TaggedImage.java before each and every build. Correct path to swig generated files in pom.xml.

Nico Stuurman added 2 commits November 29, 2023 14:55
@nicost nicost requested a review from marktsuchida November 29, 2023 23:14
Copy link
Member

@marktsuchida marktsuchida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Build from MMCoreJ_wrap.vcxproj works correctly
  • Full build from Ant (ant stage) works correctly
  • Resulting MMCoreJ.jar has same contents as before

Looks good!

@marktsuchida marktsuchida merged commit e64c67d into main Dec 1, 2023
@marktsuchida marktsuchida deleted the mvnBuild branch December 1, 2023 17:11
@marktsuchida
Copy link
Member

Oops, I forgot to test the macOS build, and it fails. Should be easy to fix, working on it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants