Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MicroFPGA #1

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Add MicroFPGA #1

merged 2 commits into from
Apr 12, 2021

Conversation

jdeschamps
Copy link
Contributor

Hi there,

Here is the device adapter for a FPGA board that the Ries lab (EMBL) and collaborators have been using for a few years on their microscopes. The platform is called MicroFPGA and is based on an hobby FPGA board from Alchitry (Au or Cu, now produced by SparkFun).

MicroFPGA generats various control signals used on microscopes such as a flexible laser triggering system, servomotors, TTL or PWM (used for instance together with a low-pass for analog output). Together with one of the FPGA board (Au), it can also read in analog signals.

We put some effort in making the project repository as documented as possible so that it is easy for people to reproduce and install on their own microscope.

@nanthony21
Copy link
Member

Thanks! Other than the minor thing that I commented on I think this is good to go.

@jdeschamps
Copy link
Contributor Author

Cheers! Where is the comment? I must have missed it. :)

@nanthony21
Copy link
Member

nanthony21 commented Apr 12, 2021

Ok, I was just asking to have the lines that are like: #include "../../MMDevice/header_file.h" changed to #include "header_file.h".

The reason is just that the MMDevice folder is already added to the include paths in the project. If, in the future, the relative path to MMDevice changes then we will only need to adjust the path in the project property rather than changing it in every source file.

I made this change in all of the existing device adapters when migrating to this repository so I'd like to maintain that for new device adapters as well.

Edit: I guess I had to click "submit review" before the comment actually appeared.

#define _Mojo_H_

#include "../../MMDevice/MMDevice.h"
#include "../../MMDevice/DeviceBase.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since MMDevice is already an include directory can these be changed to just say #include "DeviceBase.h" ?

This just saves some work later if the relative path between the device adapters and MMDevice ever changes.

@jdeschamps
Copy link
Contributor Author

Makes sense! I implemented the changes.

@nanthony21
Copy link
Member

Looks good. This should hopefully show up in tomorrow's build.

@nanthony21 nanthony21 merged commit 0401db5 into micro-manager:main Apr 12, 2021
marktsuchida pushed a commit that referenced this pull request Oct 3, 2023
… micro manager avt device adapter

Merge in HSW_SDK/mmcoreanddevices from feature/UNISDK-3114-create-jenkins-jobs-for-building-micro-manager-avt-device-adapter to allied-vision-camera-device-adapter

Squashed commit of the following:

commit 3ef56cc7e2efbdda688d732476055bfdd318a234
Author: Florian Klostermann <[email protected]>
Date:   Thu Jul 27 14:09:14 2023 +0200

    Jenkinsfile fix

commit f74b0b65cf5fce2277b17433b612915c51d52eaa
Author: Florian Klostermann <[email protected]>
Date:   Thu Jul 27 14:01:23 2023 +0200

    fixed Windows Jenkinsfile

commit bf1304f3b1afb11a19f32bbdaffd5ec0d80e2a59
Author: Florian Klostermann <[email protected]>
Date:   Thu Jul 27 11:58:32 2023 +0200

    Added Windows Jenkinsfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants