Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logging on Micro-ROS rcutils #7

Merged
merged 6 commits into from
Jul 10, 2020
Merged

Remove logging on Micro-ROS rcutils #7

merged 6 commits into from
Jul 10, 2020

Conversation

pablogs9
Copy link
Member

@pablogs9 pablogs9 commented Apr 15, 2020 •
edited by jamoralp
Loading

@pablogs9 pablogs9 requested review from jfm92 and julionce April 15, 2020 08:23
This was referenced Apr 15, 2020
Merged
Merged
Merged
Merged
@pablogs9 pablogs9 changed the base branch from master to dashing April 15, 2020 08:54
julionce
julionce reviewed Apr 23, 2020
View reviewed changes
src/error_handling.c Outdated Show resolved Hide resolved
include/rcutils/logging.h Show resolved Hide resolved
@julionce julionce assigned pablogs9 and unassigned julionce Apr 23, 2020
@pablogs9 pablogs9 assigned julionce and unassigned pablogs9 Apr 23, 2020
@julionce julionce assigned pablogs9 and unassigned julionce Apr 24, 2020
@pablogs9 pablogs9 assigned julionce and unassigned jfm92 and pablogs9 Apr 29, 2020
@pablogs9 pablogs9 removed the request for review from jfm92 April 29, 2020 08:42
@julionce julionce assigned pablogs9 and unassigned julionce Apr 30, 2020
@pablogs9 pablogs9 removed their assignment Apr 30, 2020
@pablogs9 pablogs9 requested a review from jamoralp June 18, 2020 06:16
@pablogs9 pablogs9 marked this pull request as draft June 18, 2020 06:16
@pablogs9 pablogs9 mentioned this pull request Jun 18, 2020
Closed
26 tasks
@jamoralp jamoralp marked this pull request as ready for review July 10, 2020 07:55
@jamoralp jamoralp merged commit d0407f7 into dashing Jul 10, 2020
@jamoralp jamoralp deleted the feature/remove_logging branch July 10, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julionce julionce julionce left review comments

@jamoralp jamoralp jamoralp approved these changes

Assignees

@julionce julionce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogs9 @julionce @jamoralp @jfm92