Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GNU binutils on MacOS #116

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Use GNU binutils on MacOS #116

merged 5 commits into from
Sep 4, 2023

Conversation

jkaflik
Copy link
Contributor

@jkaflik jkaflik commented Aug 30, 2023 •
edited
Loading

This enhances library_builder.py with support for homebrew-installed GNU binutils.

Unfortunately, it forces users to use Homebrew, but eventually, it's fine.

@jkaflik jkaflik marked this pull request as draft August 30, 2023 12:05
@jkaflik jkaflik closed this Aug 30, 2023
@jkaflik jkaflik reopened this Aug 30, 2023
@jkaflik jkaflik changed the title GNU ar for MacOS Use GNU binutils on MacOS Aug 30, 2023
@jkaflik jkaflik marked this pull request as ready for review August 30, 2023 13:22
@jkaflik jkaflik mentioned this pull request Aug 30, 2023
Closed
pablogs9
pablogs9 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

microros_utils/library_builder.py Outdated Show resolved Hide resolved
@pablogs9
Copy link
Member

pablogs9 commented Sep 4, 2023

I guess that something is wrong with the CI, let me check it before merging this

@pablogs9
Copy link
Member

pablogs9 commented Sep 4, 2023

Just fixed the CI: #118

Could you please rebase on top of main and revert the change commented above so I can merge?

@jkaflik
Copy link
Contributor Author

jkaflik commented Sep 4, 2023

@pablogs9 done

@pablogs9 pablogs9 merged commit 841dc13 into micro-ROS:main Sep 4, 2023
20 checks passed
@pablogs9
Copy link
Member

pablogs9 commented Sep 4, 2023

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkaflik @pablogs9