Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help with refactor ESP32 support #19

Closed
pablogs9 opened this issue Aug 6, 2020 · 1 comment
Closed

Help with refactor ESP32 support #19

pablogs9 opened this issue Aug 6, 2020 · 1 comment
Assignees

Comments

@pablogs9
Copy link
Member

pablogs9 commented Aug 6, 2020

Hello @donRaphaco, I'm removing the libatomic from the extensions repositories and adding it to rcutils package, check this: https://github.com/micro-ROS/micro_ros_setup/pull/171/checks?check_run_id=953530520

But in the case of the ESP32 I'm not able to remove the folder components/libatomics and these two lines without having building errors.

Is possible for you to remove this libatomic dependency for the ESP32 board support? I'm working in this PR: #18 You can commit there if you wish.

Thanks!

donRaphaco pushed a commit that referenced this issue Aug 6, 2020
Signed-off-by: Raphael Vogelgsang <[email protected]>
@donRaphaco
Copy link

It should be fixed with 5c87578

pablogs9 pushed a commit that referenced this issue Sep 17, 2020
Signed-off-by: Raphael Vogelgsang <[email protected]>
pablogs9 added a commit that referenced this issue Sep 17, 2020
* Simple 64 bit atomic mocks, no atomicity

* Remove atomics

* Add esp32 deps

* Update esp32

* rm libatomic from esp32 (see #19)

Signed-off-by: Raphael Vogelgsang <[email protected]>

Co-authored-by: Raphael Vogelgsang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants