Support chunks in HTTP2 - Type check

micmro · Nov 23, 2021 · 1b405ec · 1b405ec
1 parent 1d8a925
commit 1b405ec
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/ts/transformers/har.ts b/src/ts/transformers/har.ts
@@ -236,13 +236,11 @@ const getUserTimings = (currPage: Page, options: ChartOptions) => {
 /**
  * Create `WaterfallEntry`s to represent the sub-timings of a request
  * ("blocked", "dns", "connect", "send", "wait", "receive")
- * TODO: `harEntry: Entry` Entry interface doesn't have the chunks property and this fails TS.
- * I see no benefit in typechecking harEntry IMHO. But to fix this we need to import that interface and update it.
  * @param  {number} startRelative - Number of milliseconds since page load started (`page.startedDateTime`)
  * @param  {Entry} harEntry
  * @returns Array
  */
-const buildDetailTimingBlocks = (startRelative: number, harEntry): WaterfallEntryTiming[] => {
+const buildDetailTimingBlocks = (startRelative: number, harEntry: Entry): WaterfallEntryTiming[] => {
   const t = harEntry.timings;
   const chunks = harEntry._chunks || [];
   const types: TimingType[] = ["blocked", "dns", "connect", "send", "wait", "receive"];

diff --git a/src/ts/waterfall/row/svg-row-subcomponents.ts b/src/ts/waterfall/row/svg-row-subcomponents.ts
@@ -60,6 +60,7 @@ function makeBlock(rectData: RectData, className: string) {
 function makeChunkBlock(chunkData, rectData: RectData, className: string) {
   const holder = svg.newG("");
   const blockHeight = rectData.height - 1;
+  // TODO: Once we have a way to pass the available bandwidth we can calculate the length for each chunk.
   // const blockWidth = chunkData.ts - (chunkData.bytes / (5000000 / 8.0));
   const rectX = misc.roundNumber(chunkData.ts / rectData.unit) + "%";
   const rect = svg.newRect({