Fix serverinfo overflow - reduce version cvar #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitigate the serverinfo overflow issue by reducing the version cvar length which is somewhat longer than the official engine by 33 chars. - Abbreviate PRODUCT_NAME to match official (will affect pid filenames) - Remove redundant product name from makeFile VERSION - Reduce git info to rev alone (commit date can be inferred from hash) Mitigates mickael9#30
The **q** in ioq3 is always lowercase!
|
Looks good to me 👍 |
|
Hah 😮 weird, i'm surprised how biddy is able to commit to my fork. Is this some new github thing where there are soft priviledges through PRs? handy I guess. |
|
If you check the |
mickael9
reviewed
Apr 10, 2018
| @@ -474,7 +474,7 @@ int Q_isnan(float x); | |||
| #endif | |||
| /* | |||
| // if your system does not have lrintf() and round() you can try this block. Please also open a bug report at bugzilla.icculus.org | |||
| // or write a mail to the ioq3 mailing list. | |||
| // or write a mail to the 3 mailing list. | |||
There was a problem hiding this comment.
He didn't fix the typo, did he? 😄
There was a problem hiding this comment.
Ya this might be getting too terse :P
There was a problem hiding this comment.
Oh snap, dunno how that ioq3 changed into a 3. Must have been a fail when searching all the ioq3 occurences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Karnute's (separate) patch should handle actual overflows more gracefully, but this still helps mitigate the chance of it happening a little bit.
Fixes #30