Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set API Key & API Key Secret manually #319

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

EricFrancis12
Copy link
Contributor

These changes enable setting Twitter API Key & API Key Secret manually, without removing any existing functionality.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (8855f22) to head (256851b).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   84.41%   84.46%   +0.05%     
==========================================
  Files          97       97              
  Lines        2630     2640      +10     
==========================================
+ Hits         2220     2230      +10     
  Misses        381      381              
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michimani michimani requested review from michimani and removed request for michimani September 18, 2024 14:07
client.go Outdated Show resolved Hide resolved
@EricFrancis12
Copy link
Contributor Author

@michimani Thanks for your review.

I corrected the capitalization.

Also, it looks like SetAPIKey() and SetAPIKeySecret() are not needed after all, as authorize() is only called inside of NewClient(). So I removed them from the PR.

@michimani
Copy link
Owner

@EricFrancis12

Thank you for your pull request for additional features!

I will merge this PR and incorporate it into the next version.

Once again, thank you for your contribution!

@michimani michimani added the enhancement New feature or request label Sep 19, 2024
@michimani michimani self-assigned this Sep 19, 2024
@michimani michimani merged commit 8abb233 into michimani:main Sep 19, 2024
1 check passed
@EricFrancis12 EricFrancis12 deleted the set-api-creds branch September 20, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants