Skip to content

Commit

Permalink
overriding annotation and layers' control tab (apache#4609)
Browse files Browse the repository at this point in the history
  • Loading branch information
Gabe Lyons authored and michellethomas committed May 23, 2018
1 parent cdc5d60 commit 6af6105
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,13 @@ class ControlPanelsContainer extends React.Component {
const displaySectionsToRender = [];
allSectionsToRender.forEach((section) => {
if (section.controlSetRows.some(rows => rows.some(
control => controls[control] && !controls[control].renderTrigger,
))) {
control => (
controls[control] &&
(
!controls[control].renderTrigger ||
controls[control].tabOverride === 'data'
)
)))) {
querySectionsToRender.push(section);
} else {
displaySectionsToRender.push(section);
Expand Down
1 change: 1 addition & 0 deletions superset/assets/javascripts/explore/stores/controls.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -1702,6 +1702,7 @@ export const controls = {
default: [],
description: 'Annotation Layers',
renderTrigger: true,
tabOverride: 'data',
},

having_filters: {
Expand Down

0 comments on commit 6af6105

Please sign in to comment.