[bugfix] empty From date filter NoneType error (apache#3633)

Error "AttributeError: 'NoneType' object has no attribute 'split'" is fired.
michellethomas · May 23, 2018 · 2d6203d · 2d6203d
1 parent 01b1257
commit 2d6203d
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/superset/viz.py b/superset/viz.py
@@ -158,10 +158,11 @@ def query_obj(self):
         until = form_data.get("until", "now")
 
         # Backward compatibility hack
-        since_words = since.split(' ')
-        grains = ['days', 'years', 'hours', 'day', 'year', 'weeks']
-        if (len(since_words) == 2 and since_words[1] in grains):
-            since += ' ago'
+        if since:
+            since_words = since.split(' ')
+            grains = ['days', 'years', 'hours', 'day', 'year', 'weeks']
+            if (len(since_words) == 2 and since_words[1] in grains):
+                since += ' ago'
 
         from_dttm = utils.parse_human_datetime(since)