Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace injector instance by inject #824

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Replace injector instance by inject #824

merged 4 commits into from
Dec 11, 2023

Conversation

loicgreffier
Copy link
Contributor

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • [] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • [] Make sure you are making a pull request against the dev (left side). Also you should start your branch off dev.
  • [] Check the commit's or even all commits' message styles matches our requested structure.
  • [] Check your code additions will fail neither code linting checks nor unit test.
  • [] Make sure that you've add licence text on every new file you are adding to repository.

Description

Please describe your pull request.
If possible provide visual elements to illustrate your feature and

Thank you for your contribution ! 🍹

@loicgreffier loicgreffier added the enhancement This issue or pull request improves a feature label Dec 11, 2023
@loicgreffier loicgreffier changed the title Injector Replace injector instance with inject Dec 11, 2023
@loicgreffier loicgreffier changed the title Replace injector instance with inject Replace injector instance by inject Dec 11, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@loicgreffier loicgreffier merged commit 64886eb into master Dec 11, 2023
5 checks passed
@loicgreffier loicgreffier deleted the injector branch December 11, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement This issue or pull request improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loicgreffier