Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add applicationId in KafkaError schema #272

Conversation

BastienBigue
Copy link
Contributor

@BastienBigue BastienBigue commented Nov 13, 2024

Add applicationId in KafkaError schema, fill the field when used, and some tests on KafkaError building

For #249

@loicgreffier loicgreffier added the enhancement This issue or pull request improves a feature label Nov 14, 2024
Copy link
Collaborator

@loicgreffier loicgreffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BastienBigue Thank you for the PR, LGTM

@loicgreffier loicgreffier merged commit 1332dd3 into michelin:main Nov 14, 2024
1 of 2 checks passed
@BastienBigue BastienBigue deleted the feature/add-application-id-in-kafka-error-schema branch November 14, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request improves a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants