Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform file / id's classes for blockquotes #101

Open
wants to merge 1 commit into
base: lib
Choose a base branch
from
Open

transform file / id's classes for blockquotes #101

wants to merge 1 commit into from

Conversation

WickedSik
Copy link

  • Allowing ID's and classes to be added to blockquotes as well.
  • added a transformFile method

- Allowing ID's and classes to be added to blockquotes as well.
- added a transformFile method
@michelf
Copy link
Owner

michelf commented May 18, 2013

This pull should really be two pulls. Beside that, I'm not sure there's that much of a benefit in having a transform file function. I'm sure many people will interpret that as generating a full HTML file, which it doesn't, and it can't really do it either, not in a way that'll be useful to most people without a template system.

As for blockquotes with class and id, I'm not against the idea, but the solution isn't so clear. It needs to be coherent for all block-level elements (lists, paragraphs, tables...). It needs to make sense when you read it. And I'd need to check what other Markdown implementations do and decide if I should mimick them to avoid fragmentation. Basically I need to do some research before I can decide what should be done with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants