Respond with 'Sec-WebSocket-Protocol' header on connect when requested #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure this actually works? Because it wasn't supported by AWS AG v2 and according to this thread it's still unsupported. |
michalkvasnicak
requested changes
Jun 9, 2020
Deployed on aws: it worked with both playground and that chat-example-app. |
michalkvasnicak
approved these changes
Jun 9, 2020
|
Thank you very much @lepilepi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subscription wasn't working with Playground because it requested with the
Sec-WebSocket-Protocol: graphql-wsheader and expected the same to be returned on connect.With this error exactly:
Error during WebSocket handshake: Sent non-empty 'Sec-WebSocket-Protocol' header but no response was receivedThe proposed fix is to respond with that header when requested.
(Tested with both playground the the provided chat-example-app)