work on PaloAltoNetworks#92 - surface delete errors in nat rules

michalbil · Sep 22, 2022 · 789ca02 · 789ca02
1 parent 429d7e3
commit 789ca02
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/poli/nat/fw.go b/poli/nat/fw.go
@@ -146,7 +146,9 @@ func (c *Firewall) ConfigureRules(vsys string, rules []Entry, auditComments map[
 		}
 
 		if len(rmList) != 0 {
-			_ = c.Delete(vsys, rmList...)
+			if err = c.Delete(vsys, rmList...); err != nil {
+				return err
+			}
 		}
 	}
 

diff --git a/poli/nat/pano.go b/poli/nat/pano.go
@@ -151,7 +151,9 @@ func (c *Panorama) ConfigureRules(dg, base string, rules []Entry, auditComments
 		}
 
 		if len(rmList) != 0 {
-			_ = c.Delete(dg, base, rmList...)
+			if err = c.Delete(dg, base, rmList...); err != nil {
+				return err
+			}
 		}
 	}