-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
18 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,11 +11,7 @@ What works, what doesn't, and what hasn't been attempted: | |
|
||
- π’ Basic storybook init/demo stories. (Requires minor tweaks to filenames.) | ||
- π’ Typescript (components and stories) | ||
- π‘ Aliased imports. E.g. `$app/stores`. _Once the aliases are added,_ then some of these will work. | ||
- π’ `$app/env` Variables _are_ set. Notable because they make use of `import.meta.env`. | ||
- π’ `$app/paths` Can be imported but these are unset. (Need to call `set_paths` fn.) | ||
- π΄ `$app/navigation`. Closely linked to app state. Probably need to pursue some version of a [mocking strategy](https://github.com/storybookjs/storybook/issues/14952#issuecomment-1023188255). | ||
- π΄ `$app/stores` Similar story | ||
- π’ Aliased imports. E.g. `$app`, `$lib`, etc. | ||
- β Tailwind, etc. (I don't think this should be much of a problem.) | ||
- π’ Stories that are `*.stories.svelte` files (via `@storybook/addon-svelte-csf`). This appears to work just fine. I did swap out these stories for less-fancy stories just to see if this package was introducing any additional complications/limitations. (Related: https://github.com/storybookjs/storybook/issues/14952#issuecomment-862043558) | ||
|
||
|
@@ -32,9 +28,6 @@ To try to run storybook with the current repo: | |
git clone [email protected]:michaelwooley/storybook-experimental-vite.git | ||
cd storybook-experimental-vite | ||
npm i | ||
|
||
npm run build # Need to build for storybook | ||
|
||
npm run storybook | ||
``` | ||
|
||
|
@@ -230,4 +223,4 @@ Thu Jun 30 02:52:07 AM EDT 2022 | |
- https://github.com/sveltejs/kit/issues/5184 | ||
- https://github.com/madeleineostoja/sveltekit-boilerplate | ||
- https://github.com/storybookjs/storybook/issues/14952 | ||
- https://storybook.js.org/docs/react/builders/vite | ||
- https://storybook.js.org/docs/react/builders/vite |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters