Implemented menu option to select different sounds, added 2 sounds #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simongroenewolt good stuff so far. Can you fix the swiftlint issues and then we'll review? |
|
@karbassi I'll fix the swiftlint stuff and clean up a little more. |
|
@karbassi the code is ready for review now. I've added an additional sound option: 'no sound'. |
karbassi
approved these changes
Jan 8, 2021
There was a problem hiding this comment.
Code looks good. Feature works when testing. Great stuff @simongroenewolt!
Merging. 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix #49 by adding an option to the context-menu.
The selection is not persisted between launches, and is selected per timer, so if you have multiple timers running you can select different sounds for them.
Please note that I have only very limited Swift/Cocoa knowledge, so if it looks 'off' somehow that is totally expected ;-)