[feat] saving logged user to localStorage #5
Conversation
|
|
||
| this.token = localStorage.getItem('access_token'); | ||
| if (this.token) { | ||
| this.authenticated = true; |
There was a problem hiding this comment.
I believe there is a problem here, though I like what you are doing in general. I don't think you can set this.authenticated to true unless a) there is an expires value in local storage and b) that value has not passed already. We can't set auth to true if there's no expires value, and we can't set it to true if that expires value has already expired. If you can fix that up, I'll accept the new merge request.
| @@ -122,15 +135,15 @@ export class AuthService { | |||
| } | |||
|
|
|||
| public getSession() { | |||
| return {authenticated: this.authenticated, token: this.token, expires: this.expires}; | |||
| return { authenticated: this.authenticated, token: this.token, expires: this.expires }; | |||
There was a problem hiding this comment.
I would prefer that the formatting stay consistent with the rest of the code; no spaces inside the braces.
| import {Injectable, EventEmitter} from "@angular/core"; | ||
| import {WindowService} from "./window.service"; | ||
| import {Http, Headers} from "@angular/http"; | ||
| import { Injectable, EventEmitter } from "@angular/core"; |
There was a problem hiding this comment.
I would prefer that the formatting stay consistent with the rest of the code; no spaces inside the braces.
| } | ||
|
|
||
| private fetchUserInfo() { | ||
| if (this.token != null) { | ||
| var headers = new Headers(); | ||
| headers.append('Authorization', `Bearer ${this.token}`); | ||
| //noinspection TypeScriptUnresolvedFunction | ||
| this.http.get(this.oAuthUserUrl, {headers: headers}) | ||
| this.http.get(this.oAuthUserUrl, { headers: headers }) |
There was a problem hiding this comment.
I would prefer that the formatting stay consistent with the rest of the code; no spaces inside the braces.
No description provided.