[APM] Increase xpack.apm.ui.transactionGroupBucketSize (elastic#71661…

…) (elastic#71830)
michaelolo24 · Jul 15, 2020 · 8c80644 · 8c80644
1 parent a725e84
commit 8c80644
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 7 deletions.
diff --git a/docs/settings/apm-settings.asciidoc b/docs/settings/apm-settings.asciidoc
@@ -52,7 +52,7 @@ Changing these settings may disable features of the APM App.
   | Set to `false` to hide the APM app from the menu. Defaults to `true`.
 
 | `xpack.apm.ui.transactionGroupBucketSize`
-  | Number of top transaction groups displayed in the APM app. Defaults to `100`.
+  | Number of top transaction groups displayed in the APM app. Defaults to `1000`.
 
 | `xpack.apm.ui.maxTraceItems` {ess-icon}
   | Maximum number of child items displayed when viewing trace details. Defaults to `1000`.

diff --git a/x-pack/plugins/apm/server/index.ts b/x-pack/plugins/apm/server/index.ts
@@ -27,7 +27,7 @@ export const config = {
     autocreateApmIndexPattern: schema.boolean({ defaultValue: true }),
     ui: schema.object({
       enabled: schema.boolean({ defaultValue: true }),
-      transactionGroupBucketSize: schema.number({ defaultValue: 100 }),
+      transactionGroupBucketSize: schema.number({ defaultValue: 1000 }),
       maxTraceItems: schema.number({ defaultValue: 1000 }),
     }),
     telemetryCollectionEnabled: schema.boolean({ defaultValue: true }),

diff --git a/x-pack/plugins/apm/server/lib/transaction_groups/__snapshots__/fetcher.test.ts.snap b/x-pack/plugins/apm/server/lib/transaction_groups/__snapshots__/fetcher.test.ts.snap
diff --git a/x-pack/plugins/apm/server/lib/transaction_groups/__snapshots__/queries.test.ts.snap b/x-pack/plugins/apm/server/lib/transaction_groups/__snapshots__/queries.test.ts.snap
diff --git a/x-pack/plugins/apm/server/lib/transaction_groups/fetcher.ts b/x-pack/plugins/apm/server/lib/transaction_groups/fetcher.ts
@@ -72,7 +72,9 @@ export async function transactionGroupsFetcher(
       aggs: {
         transaction_groups: {
           composite: {
-            size: bucketSize + 1, // 1 extra bucket is added to check whether the total number of buckets exceed the specified bucket size.
+            // traces overview is hardcoded to 10000
+            // transactions overview: 1 extra bucket is added to check whether the total number of buckets exceed the specified bucket size.
+            size: isTopTraces ? 10000 : bucketSize + 1,
             sources: [
               ...(isTopTraces
                 ? [{ service: { terms: { field: SERVICE_NAME } } }]

diff --git a/x-pack/test/apm_api_integration/basic/tests/services/transactions/top_transaction_groups.ts b/x-pack/test/apm_api_integration/basic/tests/services/transactions/top_transaction_groups.ts
@@ -25,7 +25,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
         );
 
         expect(response.status).to.be(200);
-        expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 100 });
+        expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 1000 });
       });
     });
 

diff --git a/x-pack/test/apm_api_integration/basic/tests/traces/top_traces.ts b/x-pack/test/apm_api_integration/basic/tests/traces/top_traces.ts
@@ -24,7 +24,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
         );
 
         expect(response.status).to.be(200);
-        expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 100 });
+        expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 1000 });
       });
     });
-Original file line number
+Diff line change
@@ Expand Up @@
             );
             expect(response.status).to.be(200);
-            expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 100 });
+            expect(response.body).to.eql({ items: [], isAggregationAccurate: true, bucketSize: 1000 });
           });
         });
@@ Expand Down @@