Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reuse tab with same host #13

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

otakustay
Copy link
Contributor

No description provided.

@otakustay
Copy link
Contributor Author

Tested on Node 8, but got some error when running lint on Node 8:

yarn run v1.22.4
$ xo src/ --fix --node-version ">=10.0.0"
SyntaxError: Failed to load plugin 'unicorn' declared in 'BaseConfig » /Users/otakustay/Develop/better-opn/node_modules/xo/config/plugins.js': Invalid regular expression: /(?<=(?:^|[^\\])(?:\\\\)*\\)(?<data>x[\dA-Fa-f]{2}|u[\dA-Fa-f]{4}|u{[\dA-Fa-f]+})/: Invalid group
Referenced from: /Users/otakustay/Develop/better-opn/node_modules/xo/config/plugins.js
    at Object.<anonymous> (/Users/otakustay/Develop/better-opn/node_modules/eslint-plugin-unicorn/rules/escape-case.js:5:29)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at module.exports (/Users/otakustay/Develop/better-opn/node_modules/import-modules/index.js:47:29)
    at Object.<anonymous> (/Users/otakustay/Develop/better-opn/node_modules/eslint-plugin-unicorn/index.js:6:9)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Not sure it is something this commit introduced, or is already known.

@michaellzc michaellzc changed the title feat: support reuse tab with same host (#11) feat: support reuse tab with same host Oct 19, 2020
revert changes to applescript cuz i don't want to maintain this myself.

I'll keep it consistent with the upstream (CRA).
@michaellzc michaellzc merged commit eb96092 into michaellzc:master Oct 19, 2020
@otakustay
Copy link
Contributor Author

@ExiaSR I'm afraid your commit is not correct, "the URL for reuse tab" and "the URL to open" are different things, we need host to find a reusable tab but still open a URL with full pathname specified when no reusable tab can be found, the applescript requires both a arts

@michaellzc
Copy link
Owner

@otakustay let me know if this fixes your problem #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants