New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SCP terminal command execution #496

Merged

michaellukashov merged 2 commits into michaellukashov:main from ssvine:fix-command-exec

Nov 24, 2024

Contributor

ssvine commented Sep 28, 2024

This PR fixes issues that are related to executing commands in SCP terminal:

Panel is not refreshed. For example, after executing touch test.txt (execute command while panels are shown) the resulting file is not shown on the panel.
If a command completed successfuly (exit code 0, or maybe 1) but has some stderr output, it shows error message. This is particularly annoying for commands like wget (and many others) that can output normally to both stdout and stderr.

ssvine added 2 commits

September 28, 2024 02:38


          Redraw panel after executing command in terminal

76aef26


          Don't show errors of commands exited successfuly but with some output…

86cbc32

… to stderr

sonarcloud bot commented Sep 28, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

michaellukashov merged commit a94d243 into michaellukashov:main

2 checks passed

ssvine deleted the fix-command-exec branch

November 25, 2024 16:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet