Fix ssh crash on reconnect #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens because extern "C" function select_result throws exception but we use /EHsc flag, which leads to UB. Because of that the compiler can create a code that calls a destructor of already destroyed or never created object while doing stack unwinding.
ssvine
force-pushed
the
fix-ssh-crash-on-reconnect
branch
from
6f07eda to
e741c23
Compare
1. Remove duplicates 2. Remove flags that are included by default 3. Fix: NETBOX_DLL_LINK_FLAGS was not included in xxx_RELEASE and xxx_DEBUG 4. Make Release, RelWithDebInfo, and MinSizeRel configs use the same linker flags
1. Remove explicit /O1 and /O2, CMake adds them 2. Remove flags that are implied by /O1 and /O2 flags 3. Remove /Ob1, /Ob2 to redefine CMake's choice 4. Remove /GS- (as security measure) 5. Do not use DEBUG define for RelWithDebInfo
ssvine
force-pushed
the
fix-ssh-crash-on-reconnect
branch
from
b61b362 to
4cc05b5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes this external bug.
Finally, I found the root cause of the crash.
This crash happens because extern "C" function
select_resultthrows exception but we use/EHscflag, which leads to UB. Because of UB the compiler can create a code that calls a destructor of already destroyed or never created object while doing stack unwinding.Also this pull request fixes freeing of
FCallbackSetinFreeBackendfunction.UPDATE:
@michaellukashov, I updated this pull request with another one that was previously created separately, because otherwise merging them would result in a error.
So, I describe that appended PR: "Include map file in releases and fix optimizations"
There are several issues with release builds:
NetBoxcrashes andFaris able to create a crash report, that report won't contain meaningful names ofNetBoxfunctions and a random user may create an issue attaching such a problematic report. So, it's a good idea to include rather small.mapfile in the binary distribution, becauseFarcan use them to convert addresses to meaningful names. (Farreleases include.mapfiles for all executables.)This PR adds
NetBox.mapfile to the release build.It also fixes and simplifies compiler and linker flags among different build types:
Far- they are already loaded in the process address space./GS-flag as security measureDEBUGdefine forRelWithDebInfoReleasecompile for the maximum speed,RelWithDebInfo- the same asReleasebut with.pdband.mapfiles, andMinSizeRel- the same asReleasebut compiled for the smallest size