Fix hotkey problems #453
Merged
Fix hotkey problems #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New hotkey is Ctrl-Alt-F in order not to interfere with more common usage. Also fix broken protocol prefixes.
Now Far can use Ctrl-Alt-Ins as usual. Alt-Shift-Ins is retained to provide the old functionality.
Crash happens because Far translates the hotkey to Ctrl-Alt-F while plugin panel is passive which is not handled properly.
Cause: EditHistory calls MultipleEdit with arguments that are passed by reference and will be implicitly substituted in FEditHistories.push_back.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes many problems regarding hotkeys. Summary of the fixed problems:
Ctrl-G(Apply command) can also be processed asCtrl-Alt-GorCtrl-Shift-G.Ctrl-Fhotkey) inserts full file name as a "session url" likessh://user@localhost:22/tmp/abc.txtwhich is not actually the full file name. Several issues were created to argue with such a behaviour. This pull request provides a better alternative - releaseCtrl-Fhotkey and bind the action toCtrl-Alt-F.scp / sftp.Ctrl-;(Ctrl-Alt-;) shows incorrect results and may lead to a crash.NetBoxbinds two hotkeys to one action (Ctrl-Alt-Ins,Alt-Shift-Ins) not allowing Far to provide a different alternative action. It's better to keep only one hotkey (Alt-Shift-Ins), thereby allowing users to use both actions.Alt-Shift-W) when editing a file.Altmodifier inAlt-Righthotkey (horizontal scrolling), also horizontal scrolling is not working.Pos. 2 mention this issues: 1 and 2