Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Alt-F12 history navigation #446

Merged

Conversation

ssvine
Copy link
Contributor

@ssvine ssvine commented Mar 31, 2024

The pull request fixes this issue.

It introduces two fixes:

  • Fix history navigation inside the connected session. This prevents an already open session from being reopened (if not needed) when using Alt-F12 history menu
  • Fix history navigation in the session list itself. This allows Far to correctly select folders inside the session list when the user is already there

The latter fix uses history entries like netbox:/some/session/list/folder instead of netbox:some/session/list/folder to help Far and Netbox do the job correctly.

This prevents an already open session from being reopened (if not needed) when using Alt-F12 history menu.
This allows Far to correctly select session list folders when the user is already in the session list.
Copy link

sonarcloud bot commented Mar 31, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@michaellukashov michaellukashov merged commit 623cb65 into michaellukashov:main Apr 2, 2024
2 checks passed
@ssvine ssvine deleted the fix-netbox-history-navigation branch April 3, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants