Merge branch 'main' into far3-dev-tests

ChangeLog

@@ -4,6 +4,13 @@
 <!-- next-header -->
 ## [Unreleased] - ReleaseDate
 
+## [24.2.3.596] - 2024-02-26
+
+### Fixes
+
+* gh-414 FTP: Netbox always crashes while connecting
+
+
 ## [24.2.2.595] - 2024-02-25
 
 ### Fixes

src/NetBox/NetBox.rc

@@ -12,13 +12,13 @@ FILETYPE 0x2
         {
             VALUE "CompanyName", "Mikhail Lukashov\0"
             VALUE "FileDescription", "NetBox: SFTP/FTP/FTPS/SCP/WebDAV/S3 client for Far Manager 3.0\0"
-            VALUE "FileVersion", "24.2.2.595\0"
+            VALUE "FileVersion", "24.2.3.596\0"
             VALUE "InternalName", "FarNetBox\0"
             VALUE "LegalCopyright", "(c) 2011, 2024 Mikhail Lukashov\0"
             VALUE "LegalTrademarks", "\0"
             VALUE "OriginalFilename", "NetBox.dll\0"
             VALUE "ProductName", "NetBox\0"
-            VALUE "ProductVersion", "24.2.2.595\0"
+            VALUE "ProductVersion", "24.2.3.596\0"
             VALUE "ReleaseType", "beta\0"
             VALUE "WWW", "https://github.com/michaellukashov/Far-NetBox\0"
         }

src/NetBox/plugin_version.hpp

@@ -6,5 +6,5 @@
 
 #define NETBOX_VERSION_MAJOR         24
 #define NETBOX_VERSION_MINOR         2
-#define NETBOX_VERSION_PATCH         2
-#define NETBOX_VERSION_BUILD         595
+#define NETBOX_VERSION_PATCH         3
+#define NETBOX_VERSION_BUILD         596

src/core/FtpFileSystem.cpp

@@ -4481,8 +4481,6 @@ bool TFTPFileSystem::HandleAsyncRequestNeedPass(
       }
     }
 
-    free(Data.Password);
-    Data.Password = nullptr;
     // When returning REPLY_OK, we need to return an allocated password,
     // even if we were returning and empty string we got on input.
     if (RequestResult == TFileZillaIntf::REPLY_OK)