Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization clarification #86

Merged
merged 5 commits into from
Dec 18, 2020

Conversation

zakv
Copy link
Collaborator

@zakv zakv commented Dec 17, 2020

Fixes #85.

Changes proposed in this pull request:

  • Rename the GaussianProcessVisualizer methods plot_hyperparameters_vs_run and plot_noise_level_vs_run to end in vs_fit().
    • Update the x-axis labels and docstrings to say fit number.
    • Mention that there is one fit per generation in the docstring.
    • Keep the methods with the old "vs_run" names for now. Make them issue a deprecation warning then call the methods with the new names.
  • Update the argument names in GaussianProcessLearner.create_visualizations() to reflect the new method names.
    • Add **kwargs and check for old variable names for backwards compatibility. Issue a deprecation warning if they are used.
    • Update docstring.
  • Change the docstring, x-axis label, and title in NeuralNetVisualizer.plot_losses() to say epochs instead of training run.
    • Change the indices on the x-axis to be 0, 10, 20... instead of 0,1, 2... since those are the number of epochs.
    • Mention in the docstring that the loss is recorded every 10 epochs.
  • Update visualizations.rst to reflect the changes.

zakv added 4 commits December 17, 2020 05:14
…() and plot_noise_level_vs_run() to plot_hyperparameters_vs_fit() and plot_noise_level_vs_fit().
…_hyperparameters_vs_run and plot_noise_level_vs_run to plot_hyperparameters_vs_fit and plot_noise_level_vs_fit to match the new method names.
docs/visualizations.rst Outdated Show resolved Hide resolved
@zakv zakv merged commit 7308657 into michaelhush:master Dec 18, 2020
@zakv zakv deleted the visualization-clarification branch December 18, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some visualization method names and plot labels are misleading
2 participants