Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few bugs with scalings, which I've patched in this PR.
The first one is that the uncertainties were scaled the wrong way in
GuassianProcessLearner
. When normalizing costs, thecost_scaler
divides them bycost_scaler.scale_
(see here) and when rescaling costs back to their original range it multiplies the scaled cost bycost_scaler.scale_
(see here). The same should be done for the uncertainties, but previously the multiplication and division were switched. This PR corrects that issue. Furthermore the uncertainties inGaussianProcessVisualizer.return_cross_sections()
weren't rescaled back, and this has been corrected as well.The second issue is more minor. The value of
cross_parameter_arrays
inGaussianProcessLearner.return_cross_sections()
andNeuralNetLearner.return_cross_sections()
was scaled previously, but does not need to be scaled. When it is created, its values go betweenself.min_boundary
andself.max_boundary
which aren't scaled, so there's no scaling to undo. This was likely a small mix-up where the scaling was meant to be applied touncertainty_arrays
but was accidentally applied tocross_parameter_arrays
instead, and then that mix-up was copy/pasted toNeuralNetVisualizer.return_cross_sections()
. Fortunately the value returned forcross_parameter_arrays
isn't used anywhere in M-LOOP, so it didn't cause any other issues.Changes proposed in this pull request:
GaussianProcessLearner
andGaussianProcessVisualizer
cross_parameter_arrays
scaling inGaussianProcessVisualizer
andNeuralNetVisualizer
@qctrl/support @charmasaur