-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop tensorflow-macos requirement #179
Conversation
As of [Tensorflow 2.16.1](https://github.com/tensorflow/tensorflow/releases/tag/v2.16.1) `tensorflow-macos` has been deprecated. Releases of `tensorflow>=2.16.1` cannot be properly installed with `tensorflow-macos`. The solution is for `m-loop` to require `tensorflow>=2.16.1`
uses can specify tensorflow-macos if needed
Hmm, the default Anaconda channel still only has 2.12.0 as it latest release. Then installing M-LOOP (with pip) would install newer tensorflow from PyPI. However, last I checked, installing tensorflow in a conda environment using pip would complete successfully, but then importing M-LOOP would cause errors with huge/incomprehensible tracebacks. I'll check to see if that's still an issue. Unfortunately M-LOOP doesn't have CI set up. I can test things out on my linux box to see whether it works there, but could you try building the environment and running Also, could you also update the minimum required tensorflow version listed in the "Dependencies" section of |
Oh and it looks to me like |
I set up an environment, installed with pip, and ran the test suite without issue on my Mac. |
Awesome, I ran the following on my Ubuntu 20.04 box with these changes and the
So seems like installing tensorflow with pip in a conda environment is no longer an issue.
|
As of Tensorflow 2.16.1
tensorflow-macos
has been deprecated.Releases of
tensorflow>=2.16.1
cannot be properly installed withtensorflow-macos
.The solution is for
m-loop
to drop thetensorflow-macos
requirement and requiretensorflow>=2.16.1
.